backupccl: set kv.bulkio.write_metadata_sst.enabled to default false #86809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
force-pushed
the
butler-sst-metadata
branch
from
7991dc8 to
5857589
Compare
msbutler
force-pushed
the
butler-sst-metadata
branch
from
5857589 to
7ea3af4
Compare
stevendanna
reviewed
Aug 25, 2022
This patch sets write_metadata_sst cluster setting to false in prep for the 22.2 branch cut, as there's additional work required before this feature gets used in production. Unit tests may continue to write the MetadataSST because of a new MetamorphicTestBool. Setting this to false will also stop the roachtest in cockroachdb#86289 from consistently failing due to cockroachdb#86806. Fixes cockroachdb#86289 Release note: none Release justification: prevents using an experimental feature by default
msbutler
force-pushed
the
butler-sst-metadata
branch
from
7ea3af4 to
f74435a
Compare
stevendanna
approved these changes
Aug 25, 2022
|
TFTR! bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sets write_metadata_sst cluster setting to false in prep for the
22.2 branch cut, as there's additional worked required before this feature gets
used in production.
Setting this to false will also stop the roachtest in #86289 from consistently
failing due to #86806.
Fixes #86289
Release note: none
Release justification: prevents using an experimental feature by default